Fix vimeo#3625 - getIterator call is used inside loop

danog · Jan 29, 2021 · 26352d0 · 26352d0
1 parent 5b8169f
commit 26352d0
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Block/ForeachAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Block/ForeachAnalyzer.php
@@ -787,12 +787,18 @@ public static function handleIterable(
                         $statements_analyzer->addSuppressedIssues(['PossiblyUndefinedMethod']);
                     }
 
+                    $was_inside_call = $context->inside_call;
+
+                    $context->inside_call = true;
+
                     \Psalm\Internal\Analyzer\Statements\Expression\Call\MethodCallAnalyzer::analyze(
                         $statements_analyzer,
                         $fake_method_call,
                         $context
                     );
 
+                    $context->inside_call = $was_inside_call;
+
                     if (!in_array('PossiblyInvalidMethodCall', $suppressed_issues, true)) {
                         $statements_analyzer->removeSuppressedIssues(['PossiblyInvalidMethodCall']);
                     }

diff --git a/tests/UnusedVariableTest.php b/tests/UnusedVariableTest.php
@@ -2203,6 +2203,27 @@ function test(Exception $e): callable {
                         return fn() => $e->getMessage();
                     }'
             ],
+            'useImmutableGetIteratorInForeach' => [
+                '<?php
+                    /**
+                     * @psalm-immutable
+                     */
+                    class A implements IteratorAggregate
+                    {
+                        /**
+                         * @return Iterator<int>
+                         */
+                        public function getIterator() {
+                            yield from [1, 2, 3];
+                        }
+                    }
+
+                    $a = new A();
+
+                    foreach ($a as $v) {
+                        echo $v;
+                    }'
+            ],
         ];
     }