Fix vimeo#4306 - negating positive-numeric is useless, avoid crash

danog · Jan 29, 2021 · 01781af · 01781af
1 parent 4f5a3ca
commit 01781af
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/Psalm/Internal/Type/NegatedAssertionReconciler.php b/src/Psalm/Internal/Type/NegatedAssertionReconciler.php
@@ -67,6 +67,10 @@ public static function reconcile(
             );
         }
 
+        if ($is_equality && $assertion === 'positive-numeric') {
+            return $existing_var_type;
+        }
+
         if (!$is_equality) {
             if ($assertion === 'isset') {
                 if ($existing_var_type->possibly_undefined) {

diff --git a/tests/TypeReconciliation/ValueTest.php b/tests/TypeReconciliation/ValueTest.php
@@ -775,6 +775,12 @@ function x(?string $foo): void {
                         if ($foo) {}
                     }',
             ],
+            'allowCheckOnPositiveNumericInverse' => [
+                '<?php
+                    function foo(int $a): void {
+                        if (false === ($a > 1)){}
+                    }'
+            ],
         ];
     }