Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(unvired-cordova-sdk): Update the return type for startDiscoveryService api #3647

Merged
merged 45 commits into from May 11, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
54ca5c1
feat(unvired-cordova-sdk): support login via email
Aug 2, 2019
54266e9
fix(unvired-cordova-sdk): return typed promise object for user settings
Aug 2, 2019
adda8b9
fix(unvired-cordova-sdk): change return type to string for guid()
Aug 2, 2019
d2c3b6f
Merge commit 'f6e77db7b06f391fe31e4367101cbc9d2fccb369'
Aug 2, 2019
a3c6154
doc(unvired-cordova-sdk): doc update
Aug 6, 2019
5d5e799
Merge commit '64ca73e5ccf4163fcd4044257d875727f34c0b39'
Aug 19, 2019
08418d9
doc(unvired-cordova-sdk): update doc
Aug 20, 2019
05e984b
feat(unvired-cordova-sdk): add support for metadata JSON
Aug 22, 2019
dece93b
doc(unvired-cordova-sdk): update doc
Aug 30, 2019
c5b2a4e
doc(unvired-cordova-sdk): update doc
Sep 17, 2019
22d9583
Merge commit '3f172cc2b89f139a7bace275b93af37661b75f4a'
Sep 17, 2019
6293fc0
Merge commit '409a985142df4fe6956ec465921a0b062aaa61e6'
Oct 22, 2019
5a66578
feat(unvired-cordova-sdk): add methods to get and set log level
Oct 22, 2019
c8521c6
fix(unvired-cordova-sdk): update the return type for getLog()
Oct 23, 2019
112a9e5
feat(unvired-cordova-sdk): return platform name
Oct 25, 2019
e425b98
Merge commit '996bf00e850d43374b88fd2f0f417cff587d0650'
Nov 7, 2019
cbd1201
feat(unvired-cordova-sdk): add method to get log file path
Nov 7, 2019
b8e8f6f
feat(unvired-cordova-sdk): test push notifications
Nov 7, 2019
d382ceb
fix(unvired-cordova-sdk): define return for logRead
Nov 11, 2019
47ad3de
Merge commit 'b8695220eae02bdefcb72a3729df5d01be80a36f'
Dec 5, 2019
d700653
doc(unvired-cordova-sdk): remove mobile only restriction for some apis
Dec 5, 2019
e0afe81
feat(unvired-cordova-sdk): add new property containing HTTP status code.
Jan 29, 2020
8987ab9
Merge commit '1bcaa39ffdea7f273c2a30ae0ffc5a322c08edf0'
Jan 29, 2020
bd42d90
Merge commit '7277c0fbe5531f9faaab562fb7d715344b7ceaf8'
Feb 27, 2020
af3c82d
feat(unvired-cordova-sdk): add new functions to lock & unlock sending…
Feb 27, 2020
4af32cd
fix(unvired-cordova-sdk): update the return type for lock and unlock …
Feb 27, 2020
8d06492
fix(unvired-cordova-sdk): change the return type for lockDataSender api
Feb 27, 2020
5f19cb1
fix(unvired-cordova-sdk): fix the data type for ResultType and Outbox…
Feb 29, 2020
5e7a023
Merge branch 'master' into master
srinidhirao Feb 29, 2020
52df88d
doc(unvired-cordova-sdk): Update doc
Jun 25, 2020
59f4044
Merge branch 'master' of https://github.com/srinidhirao/ionic-native
Jun 25, 2020
fc8854f
doc(unvired-cordova-sdk): Update doc
Jun 25, 2020
9ca13e3
feat(unvired-cordova-sdk): Added new notification type
Aug 7, 2020
1c08dc2
Merge branch 'master' into master
srinidhirao Oct 1, 2020
aa34d6a
feat(unvired-cordova-sdk): delete outbox item based on lid
Oct 16, 2020
c540907
fix(unvired-cordova-sdk): Update doc
Dec 8, 2020
75f0fe7
doc(unvired-cordova-sdk): Update doc for userSettings()
Jan 11, 2021
d05a8d1
Merge commit '239ae32ad3cd281a63df4b1cb275785400ebd430'
Mar 2, 2021
2cde98c
feat(unvired-cordova-sdk): add new discovery api
Mar 2, 2021
af13cc1
fix(unvired-cordova-sdk): rename the property
Mar 5, 2021
7d0c896
doc(unvired-cordova-sdk): Doc update
Mar 30, 2021
9798711
Merge commit '6c99c3be03152de44cb8fa6683fcf0f32eed19a1'
Apr 6, 2021
82cf217
fix(unvired-cordova-sdk): Update the return type for startDiscoverySe…
Apr 6, 2021
b698a19
doc(unvired-cordova-sdk): Rename the loginParameter languageCode to l…
Apr 6, 2021
77d38a0
changes after doing npm install
Apr 6, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
26 changes: 13 additions & 13 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

31 changes: 15 additions & 16 deletions src/@ionic-native/plugins/unvired-cordova-sdk/index.ts
Expand Up @@ -400,7 +400,7 @@ export class LoginParameters {
* Language code to be sent to UMP. Specify a two-letter language code.
* The default value of this is 'en'.
*/
languageCode: string;
loginLanguage: string;
}
export class LoginResult extends UnviredResult {
type: LoginListenerType;
Expand Down Expand Up @@ -1494,24 +1494,23 @@ export class UnviredCordovaSDK extends IonicNativePlugin {
}

/**
* Returns an observable to return the UMP URLs which are discoverable within the network.
* Clients can use this information to allow users to select UMP servers in login page.
* Returns a promise containing UMP servers which are discoverable within the network.
* Clients can use this information to allow users to select appropriate UMP server in the login page.
* ```
* this.unviredSDK.startDiscoveryService().subscribe( (result) => {
* if (result.type == ResultType.success) {
* console.log('Discovered URLs: ' + JSON.stringify(result.data))
* // {"name":"Chyme 98","url":"http://192.168.98.98:8080/UMP/","root":"UNVIRED","type":"DEVELOPMENT"}
* }
* else {
* console.log('Error in discovering URLs: ' + result.error)
* }
* })
* let discoveryServiceResult = await this.unviredSDK.startDiscoveryService()
* if (discoveryServiceResult.type == ResultType.success) {
* let UMPServers: any[] = discoveryServiceResult.data
* UMPServers.forEach(element => {
* console.log(JSON.stringify(element)) // {"name":"Chyme 98","url":"http://192.168.98.98:8080/UMP/","root":"UNVIRED","type":"DEVELOPMENT"}
* });
* }
* else {
* console.log('Error searching for UMP Servers: ' + discoveryServiceResult.error)
* }
* ```
*/
@Cordova({
observable: true,
})
startDiscoveryService(): Observable<UnviredResult> {
@Cordova()
startDiscoveryService(): Promise<UnviredResult> {
return;
}
}