Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TargetDescriptionXmlOverride extension #43

Merged
merged 3 commits into from Mar 19, 2021

Conversation

daniel5151
Copy link
Owner

@daniel5151 daniel5151 commented Mar 19, 2021

Building off of @DrChat's work in #42 (closes #42)

Remember how I said I'd try and tackle #12 as part of this PR as well? Well... after refreshing myself on the details of the underlying qXfer:features:read API, I realized that my idea wouldn't actually work. The changes will require a bit more thought and effort, and aren't something I'd be able to hack out in an afternoon.

As such, I've kept this PR's scope limited to just allowing target-dependent target description XML files.

@daniel5151 daniel5151 changed the title add target description XML override extension Add TargetDescriptionXmlOverride extension Mar 19, 2021
Copy link
Contributor

@DrChat DrChat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue, but can be ignored. Otherwise, LGTM 👍

src/target/ext/target_description_xml_override.rs Outdated Show resolved Hide resolved
@daniel5151
Copy link
Owner Author

Alrighty, I'll go ahead and merge this into master, and I'll push out a 0.4.5 release sometime tomorrow

@DrChat
Copy link
Contributor

DrChat commented Mar 19, 2021

Perfect! Appreciate it.

@daniel5151 daniel5151 merged commit 1593da2 into master Mar 19, 2021
@daniel5151 daniel5151 deleted the feature/override-target-description-xml branch March 19, 2021 15:44
@daniel5151
Copy link
Owner Author

Alright, gdbstub 0.4.5 is now published with this new feature. Enjoy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants