switch Signal from enum to struct + associated consts

closes #120
daniel5151 · Apr 29, 2023 · 5afd432 · 5afd432
1 parent 3bc0163
commit 5afd432
Show file tree

Hide file tree

Showing 5 changed files with 318 additions and 487 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 
 #### Breaking API Changes
 
+- `Signal` is not longer an `enum`, and is instead a `struct` with a single `pub u8` field + a collection of associated constants.
 - `Arch` API:
   - Entirely removed `single_step_behavior`. See [\#132](https://github.com/daniel5151/gdbstub/pull/132) for details and rationale
 - `Target` APIs:

diff --git a/README.md b/README.md
@@ -178,8 +178,6 @@ The following list exhaustively documents all uses of `unsafe` in `gdbstub`:
   - Don't emit provably unreachable panics
     -   `src/protocol/packet.rs`: Method in `PacketBuf` that use index using stored sub-`Range<usize>` into the buffer
     -   `src/protocol/common/hex.rs`: `decode_hex_buf`
-  - Don't emit large `match`-arm LUT
-    - `src/common.rs`: Checked transmute of `u8` to `Signal`
 
 -   When the `std` feature is enabled:
     -   `src/connection/impls/unixstream.rs`: An implementation of `UnixStream::peek` which uses `libc::recv`. Will be removed once [rust-lang/rust#76923](https://github.com/rust-lang/rust/issues/76923) stabilizes this feature in the stdlib.