1.63 clippy lints

daniel5151 · Aug 17, 2022 · 55c5343 · 55c5343
1 parent 1458f21
commit 55c5343
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/gdbstub_arch/src/riscv/reg/riscv.rs b/gdbstub_arch/src/riscv/reg/riscv.rs
@@ -10,7 +10,7 @@ use gdbstub::internal::LeBytes;
 /// Useful links:
 /// * [GNU binutils-gdb XML descriptions](https://github.com/bminor/binutils-gdb/blob/master/gdb/features/riscv)
 /// * [riscv-tdep.h](https://github.com/bminor/binutils-gdb/blob/master/gdb/riscv-tdep.h)
-#[derive(Debug, Default, Clone, PartialEq)]
+#[derive(Debug, Default, Clone, PartialEq, Eq)]
 pub struct RiscvCoreRegs<U> {
     /// General purpose registers (x0-x31)
     pub x: [U; 32],

diff --git a/gdbstub_arch/src/x86/reg/core32.rs b/gdbstub_arch/src/x86/reg/core32.rs
@@ -8,7 +8,7 @@ use super::{X86SegmentRegs, X87FpuInternalRegs, F80};
 ///
 /// Source: <https://github.com/bminor/binutils-gdb/blob/master/gdb/features/i386/32bit-core.xml>
 /// Additionally: <https://github.com/bminor/binutils-gdb/blob/master/gdb/features/i386/32bit-sse.xml>
-#[derive(Debug, Default, Clone, PartialEq)]
+#[derive(Debug, Default, Clone, PartialEq, Eq)]
 pub struct X86CoreRegs {
     /// Accumulator
     pub eax: u32,

diff --git a/gdbstub_arch/src/x86/reg/core64.rs b/gdbstub_arch/src/x86/reg/core64.rs
@@ -8,7 +8,7 @@ use super::{X86SegmentRegs, X87FpuInternalRegs, F80};
 ///
 /// Source: <https://github.com/bminor/binutils-gdb/blob/master/gdb/features/i386/64bit-core.xml>
 /// Additionally: <https://github.com/bminor/binutils-gdb/blob/master/gdb/features/i386/64bit-sse.xml>
-#[derive(Debug, Default, Clone, PartialEq)]
+#[derive(Debug, Default, Clone, PartialEq, Eq)]
 pub struct X86_64CoreRegs {
     /// RAX, RBX, RCX, RDX, RSI, RDI, RBP, RSP, r8-r15
     pub regs: [u64; 16],

diff --git a/gdbstub_arch/src/x86/reg/mod.rs b/gdbstub_arch/src/x86/reg/mod.rs
@@ -17,7 +17,7 @@ pub use core64::X86_64CoreRegs;
 pub type F80 = [u8; 10];
 
 /// FPU registers
-#[derive(Debug, Default, Clone, PartialEq)]
+#[derive(Debug, Default, Clone, PartialEq, Eq)]
 pub struct X87FpuInternalRegs {
     /// Floating-point control register
     pub fctrl: u32,
@@ -92,7 +92,7 @@ impl Registers for X87FpuInternalRegs {
 /// x86 segment registers.
 ///
 /// Source: <https://github.com/bminor/binutils-gdb/blob/master/gdb/features/i386/64bit-core.xml>
-#[derive(Debug, Default, Clone, PartialEq)]
+#[derive(Debug, Default, Clone, PartialEq, Eq)]
 pub struct X86SegmentRegs {
     /// Code Segment
     pub cs: u32,

diff --git a/src/stub/core_impl.rs b/src/stub/core_impl.rs
@@ -218,7 +218,7 @@ impl<T: Target, C: Connection> GdbStubImpl<T, C> {
                 // return a dummy stop reason.
                 if target.base_ops().resume_ops().is_none() && target.use_resume_stub() {
                     let is_resume_pkt = cmd
-                        .get(0)
+                        .first()
                         .map(|c| matches!(c, b'c' | b'C' | b's' | b'S'))
                         .unwrap_or(false);