Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to MDX v2 #476

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Update to MDX v2 #476

wants to merge 9 commits into from

Conversation

daniel-ac-martin
Copy link
Owner

@daniel-ac-martin daniel-ac-martin commented May 22, 2022 •
edited

@daniel-ac-martin
Copy link
Owner Author

This will require us to update our webpack config to ESM.
See: https://mdxjs.com/migrating/v2/#mdx-jsloader

@daniel-ac-martin
Label: Tweak syntax for MDX v2
5331277 
I don't think this _should_ be necesssary, but there you are.
@github-actions github-actions bot temporarily deployed to commit May 23, 2022 15:13 Inactive
@cypress
Copy link

cypress bot commented May 23, 2022 •
edited


Test summary

7 • 0 • 0 • 0

Run details
Project NotGovUK
Status Passed
Commit 607eb91
Started May 23, 2022 4:52 PM
Ended May 23, 2022 5:05 PM
Duration 13:05 💡
OS Linux Ubuntu - 20.04
Browser Multiple

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@daniel-ac-martin
Copy link
Owner Author

It looks like this will need an update to the new Storybook package before we can merge this.
See: storybookjs/mdx2-csf#9

@github-actions github-actions bot temporarily deployed to commit May 23, 2022 16:52 Inactive
@cypress
Copy link

cypress bot commented May 23, 2022


Test summary

6 • 0 • 0 • 0

Run details
Project NotGovUK
Status Passed
Commit ae62cac ℹ️
Started May 23, 2022 4:52 PM
Ended May 23, 2022 5:06 PM
Duration 13:28 💡
OS Linux Ubuntu - 20.04
Browser Multiple

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@daniel-ac-martin daniel-ac-martin mentioned this pull request Feb 14, 2023
Closed
1 task
@daniel-ac-martin
Copy link
Owner Author

See:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@daniel-ac-martin