Error on missing token (#172)

__tests__/changelog-enforcer.test.js

@@ -58,6 +58,19 @@ describe('the changelog-enforcer', () => {
       })
   })
 
+  it('should throw an error when token is missing', (done) => {
+    inputs['token'] = ''
+
+    changelogEnforcer.enforce()
+      .then(() => {
+        expect(infoSpy).not.toHaveBeenCalled()
+        expect(failureSpy).toHaveBeenCalled()
+        expect(outputSpy).toHaveBeenCalled()
+
+        done()
+      })
+  })
+
   it('should enforce when label is not present; changelog is changed', (done) => {
     inputs['skipLabels'] = 'A different label'
 
@@ -95,7 +108,7 @@ describe('the changelog-enforcer', () => {
         "raw_url": "/path/to/AnotherFile.md"
       }
     ]
-  
+
 
     fetch.mockImplementation((url, options) => {
       return prepareResponse(JSON.stringify(files))
@@ -155,8 +168,8 @@ describe('the changelog-enforcer', () => {
       }
     ]
 
-    const changelog = 
-`## [v2.1.0]
+    const changelog =
+      `## [v2.1.0]
     - Changelog   
 `
 

__tests__/client.test.js

@@ -1,6 +1,5 @@
 jest.mock('node-fetch');
 
-const core = require('@actions/core')
 const fetch = require('node-fetch')
 const { Response } = jest.requireActual('node-fetch');
 const client = require('../src/client')
@@ -58,4 +57,15 @@ describe('the client', () => {
     expect(fetch).toHaveBeenCalledTimes(2)
     expect(changelogFile).toBeUndefined()
   })
+
+  it('should get an error with bad response code', async () => {
+    fetch
+      .mockReturnValueOnce(Promise.resolve(new Response("", { status: 401 })))
+
+    try {
+      await client.findChangelog('token', 'repo', 1, 1, 'CHANGELOG.md')
+    } catch (err) {
+      expect(fetch).toHaveBeenCalled()
+    }
+  })
 })

dist/index.js

@@ -6248,7 +6248,7 @@ module.exports.enforce = async function () {
         const missingUpdateErrorMessage = getMissingUpdateErrorMessage(changeLogPath)
         const expectedLatestVersion = core.getInput(IN_EXPECTED_LATEST_VERSION)
         const versionPattern = core.getInput(IN_VERSION_PATTERN)
-        const token = core.getInput(IN_TOKEN)
+        const token = getToken()
 
         core.info(`Skip Labels: ${skipLabelList}`)
         core.info(`Changelog Path: ${changeLogPath}`)
@@ -6291,6 +6291,14 @@ function getMissingUpdateErrorMessage(changeLogPath) {
     return `No update to ${changeLogPath} found!`
 }
 
+function getToken() {
+    const token = core.getInput(IN_TOKEN)
+    if (!token) {
+        throw new Error("Did not find token for using the GitHub API")
+    }
+    return token
+}
+
 function shouldEnforceChangelog(labelNames, skipLabelList) {
     return !labelNames.some(l => skipLabelList.includes(l))
 }
@@ -6343,6 +6351,9 @@ module.exports.findChangelog = async function (token, repository, pullRequestNum
         core.debug(`Downloading page ${page} of pull request files from  /repos/${repository}/pulls/${pullRequestNumber}/files`)
         const options = addAuth(token, {})
         const response = await fetch(`https://api.github.com/repos/${repository}/pulls/${pullRequestNumber}/files?per_page=${pageSize}&page=${page}`, options)
+        if (!response.ok) {
+            throw new Error(`Got a ${response.status} response from GitHub API`)
+        }
         const files = await response.json()
         core.debug(`Downloaded page ${page} of pull request files`)
 
@@ -6366,6 +6377,9 @@ module.exports.downloadChangelog = async function (token, changelogUrl) {
     core.debug(`Downloading changelog from ${changelogUrl}`)
     const options = addAuth(token, {})
     const response = await fetch(`${changelogUrl}`, options)
+    if (!response.ok) {
+        throw new Error(`Got a ${response.status} response from GitHub API`)
+    }
     const changelog = await response.text()
     core.debug("Downloaded changelog")
     return changelog

src/changelog-enforcer.js

@@ -23,7 +23,7 @@ module.exports.enforce = async function () {
         const missingUpdateErrorMessage = getMissingUpdateErrorMessage(changeLogPath)
         const expectedLatestVersion = core.getInput(IN_EXPECTED_LATEST_VERSION)
         const versionPattern = core.getInput(IN_VERSION_PATTERN)
-        const token = core.getInput(IN_TOKEN)
+        const token = getToken()
 
         core.info(`Skip Labels: ${skipLabelList}`)
         core.info(`Changelog Path: ${changeLogPath}`)
@@ -66,6 +66,14 @@ function getMissingUpdateErrorMessage(changeLogPath) {
     return `No update to ${changeLogPath} found!`
 }
 
+function getToken() {
+    const token = core.getInput(IN_TOKEN)
+    if (!token) {
+        throw new Error("Did not find token for using the GitHub API")
+    }
+    return token
+}
+
 function shouldEnforceChangelog(labelNames, skipLabelList) {
     return !labelNames.some(l => skipLabelList.includes(l))
 }

src/client.js

@@ -8,6 +8,9 @@ module.exports.findChangelog = async function (token, repository, pullRequestNum
         core.debug(`Downloading page ${page} of pull request files from  /repos/${repository}/pulls/${pullRequestNumber}/files`)
         const options = addAuth(token, {})
         const response = await fetch(`https://api.github.com/repos/${repository}/pulls/${pullRequestNumber}/files?per_page=${pageSize}&page=${page}`, options)
+        if (!response.ok) {
+            throw new Error(`Got a ${response.status} response from GitHub API`)
+        }
         const files = await response.json()
         core.debug(`Downloaded page ${page} of pull request files`)
 
@@ -31,6 +34,9 @@ module.exports.downloadChangelog = async function (token, changelogUrl) {
     core.debug(`Downloading changelog from ${changelogUrl}`)
     const options = addAuth(token, {})
     const response = await fetch(`${changelogUrl}`, options)
+    if (!response.ok) {
+        throw new Error(`Got a ${response.status} response from GitHub API`)
+    }
     const changelog = await response.text()
     core.debug("Downloaded changelog")
     return changelog