New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace DANGER_MANUAL_PR with DANGER_MANUAL_PR_NUM in changelog #1437

Merged

orta merged 1 commit into danger:main from 7rulnik:main

Apr 16, 2024

Contributor

7rulnik commented Apr 16, 2024 •

edited

It took me a while to figure out why I was getting 327 instead of the value that I passed :D

danger-js/source/ci_source/providers/Fake.ts

Line 10 in 9d9bd6e

    
           pr: env.DANGER_TEST_PR || env.DANGER_MANUAL_PR_NUM || "327", // TODO: default to empty string ?

Also, I think a fake provider is worth documenting it, but it's another issue


          Update CHANGELOG.md

244a4cf

Member

orta commented Apr 16, 2024

👍 - yeah, no idea where that number came from

orta merged commit 2ff6dad into danger:main

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment