Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the init CLI #1436

Merged
merged 3 commits into from Apr 16, 2024
Merged

Improve the init CLI #1436

merged 3 commits into from Apr 16, 2024

Conversation

orta
Copy link
Member

@orta orta commented Apr 16, 2024

It's been 7 years, time for a re-look.

@orta orta merged commit f9c165f into main Apr 16, 2024
4 checks passed
@7rulnik
Copy link
Contributor

7rulnik commented Apr 21, 2024

@orta feels that something went wrong here

❯ yarn danger init
Welcome to Danger Init - this will take you through setting up Danger for this project.
There are four main steps we need to do:

(node:77660) [DEP0170] DeprecationWarning: The URL http://git@github.com:KosyanMedia/selene.git is invalid. Future versions of Node.js will throw an error.
(Use `node --trace-deprecation ...` to show where the warning was created)
 - [ ] Create a Dangerfile and add a few simple rules.
 - [ ] Potentially create a GitHub account for Danger to use, for messaging.
 - [ ] Set up an access token for Danger to comment with.
 - [ ] Set up Danger to run on your CI.

But before we start, we need one bit of information from you.
Is this is for an Open Source or private project?

[1] Open Source
[2] Private Repo
[0] CANCEL

1

## Step 1: Creating a starter Dangerfile


I've set up an example Dangerfile for you in this folder.

node:fs:2350
    validateStringAfterArrayBufferView(data, 'data');
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of Promise
    at Object.writeFileSync (node:fs:2350:5)
    at /Users/v7rulnik/projects/selene/node_modules/danger/distribution/commands/danger-init.js:177:20
    at step (/Users/v7rulnik/projects/selene/node_modules/danger/distribution/commands/danger-init.js:53:23)
    at Object.next (/Users/v7rulnik/projects/selene/node_modules/danger/distribution/commands/danger-init.js:34:53)
    at fulfilled (/Users/v7rulnik/projects/selene/node_modules/danger/distribution/commands/danger-init.js:25:58) {
  code: 'ERR_INVALID_ARG_TYPE'
}

@orta
Copy link
Member Author

orta commented Apr 22, 2024

Thanks! Must be the prettier changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants