Fix the shouldUseGitHubOverride logic for ESM imports #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `shouldUseGitHubOverride` util is called with `Module._load` parameters. So far, it assumed it will get a string `request` and a `NodeModule` `parent` parameters. However, for ESM imports `parent` is actually `undefined`. Account for this in code by making `parent` an optional argument; add a test. Fixes dangergh-1421
fbartho
approved these changes
Mar 14, 2024
mgol
commented
Mar 14, 2024
|
|
||
| it("ignores modules without a parent", () => { | ||
| const module = "./peril" | ||
| const parent: any = undefined |
There was a problem hiding this comment.
I could avoid the type here - the following would work as well:
Suggested change
| const parent: any = undefined | |
| const parent = undefined |
but I used what's more consistent with the other test cases.
Let me know if you'd like to drop this any.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
shouldUseGitHubOverrideutil is called withModule._loadparameters. So far, it assumed it will get a stringrequestand aNodeModuleparentparameters. However, for ESM importsparentis actuallyundefined.Account for this in code by making
parentan optional argument; add a test.Fixes gh-1421
cc @fbartho