Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eslint-plugin-jsdoc package version for node18 #1426

Merged
merged 3 commits into from Feb 22, 2024
Merged

Fix eslint-plugin-jsdoc package version for node18 #1426

merged 3 commits into from Feb 22, 2024

Conversation

th-le
Copy link
Contributor

@th-le th-le commented Feb 22, 2024

Previous PR #1425 broke the build due to incompatibility of a package on node18.

This PR updates the version for eslint-plugin-jsdoc package

Tested building docker on local

@th-le
Copy link
Contributor Author

th-le commented Feb 22, 2024

Hi @orta, thanks for merging the previous PR, could you take a look on this as well ? thanks

@orta
Copy link
Member

orta commented Feb 22, 2024

👍🏻

@orta orta merged commit 81645a6 into danger:main Feb 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@th-le @orta