Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gitlab: Upgrade @gitbeaker/node from ^21.3.0 to ^35.8.1 [platform] GitLab #1406

Merged
merged 6 commits into from
Sep 22, 2023
Merged

Gitlab: Upgrade @gitbeaker/node from ^21.3.0 to ^35.8.1 [platform] GitLab #1406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
031f01d
issue-1301: use types
ivankatliarchuk Oct 9, 2022
9dcb060
Update to @gitbeaker/node 35.8.1, fix types & tests
buffcode Sep 21, 2023
7018c2e
Update Changelog
buffcode Sep 21, 2023
ea7e389
Update DTS
buffcode Sep 21, 2023
a440525
CI: Use --esModuleInterop
buffcode Sep 22, 2023
7113be5
Fixes for DTS and flow types, replaced rest of GitLabDSL types
buffcode Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:

# Validate related tooling
- run: yarn declarations
- run: yarn tsc distribution/danger.d.ts
- run: yarn tsc --esModuleInterop distribution/danger.d.ts
- run: rm -rf node_modules/@types/babel-*
- run: rm -rf node_modules/@types/babylon

Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
## Main

<!-- Your comment below this -->
- GitLab: Upgrade `@gitbeaker/node` from `^21.3.0` to `^35.8.1` [@buffcode]
<!-- Your comment above this -->

## 11.2.8
Expand Down Expand Up @@ -1963,6 +1964,7 @@ Not usable for others, only stubs of classes etc. - [@orta]
[@azz]: https://github.com/azz
[@bdotdub]: https://github.com/bdotdub
[@bigkraig]: https://github.com/bigkraig
[@buffcode]: https://github.com/buffcode
[@caffodian]: https://github.com/caffodian
[@codestergit]: https://github.com/codestergit
[@cwright017]: https://github.com/Cwright017
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,8 @@
"debug": "^4.1.1",
"fast-json-patch": "^3.0.0-1",
"get-stdin": "^6.0.0",
"@gitbeaker/node": "^21.3.0",
"@gitbeaker/core": "^35.8.1",
"@gitbeaker/node": "^35.8.1",
"http-proxy-agent": "^5.0.0",
"https-proxy-agent": "^5.0.1",
"hyperlinker": "^1.0.0",
Expand Down
2 changes: 1 addition & 1 deletion scripts/create-danger-dts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ fs.writeFileSync("types/index.d.ts", "// TypeScript Version: 2.2\n" + output)

import * as ts from "typescript"

const program = ts.createProgram(["source/danger.d.ts"], { noEmit: true })
const program = ts.createProgram(["source/danger.d.ts"], { noEmit: true, esModuleInterop: true })
const emitResult = program.emit()
const allDiagnostics = ts.getPreEmitDiagnostics(program).concat(emitResult.diagnostics)
if (allDiagnostics.length) {
Expand Down
3 changes: 2 additions & 1 deletion scripts/danger-dts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ const createDTS = () => {
//

import { Octokit as GitHub } from "@octokit/rest"
import { Gitlab } from "@gitbeaker/node"
import { Gitlab, Types } from "@gitbeaker/node"
import { Types as CoreTypes } from "@gitbeaker/core/dist"
import { File } from "parse-diff"

`
Expand Down