Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Split integration tests to own workflow #1394

Closed
wants to merge 3 commits into from
Closed

CI: Split integration tests to own workflow #1394

wants to merge 3 commits into from

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Jul 30, 2023 •
edited

Split CI file to be able override it with node 16.
Alternative fix to #1393

create-react-app doesn't allow running other versions than latest, and latest 5.0.1 requires node 16:

@glensc glensc marked this pull request as ready for review July 30, 2023 15:55
@glensc glensc changed the title CI: Split create_react_app test CI: Split integration tests to own workflow Jul 30, 2023
@glensc glensc mentioned this pull request Jul 30, 2023
Merged
@glensc
Copy link
Contributor Author

glensc commented Jul 30, 2023

@fbartho @orta this is to fix CI. See also the other solution:

Merge which one suits you more.

@orta
Copy link
Member

orta commented Jul 31, 2023

Opted to go with #1393 - thanks!

@orta orta closed this Jul 31, 2023
@glensc
Copy link
Contributor Author

glensc commented Jul 31, 2023

825d797 should be cherry-picked to some other branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glensc @orta