Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Put long node error inside html details #1392

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Jul 30, 2023

when node process errors, that huge dump of details is placed as a note. put it into HTML <details> so the code block is collapsed by default.

image

@glensc
Copy link
Contributor Author

glensc commented Jul 30, 2023

@orta
Copy link
Member

orta commented Jul 31, 2023

Cool, yeah, this seems reasonable to me 👍🏻

@orta orta merged commit c561731 into danger:main Jul 31, 2023
1 of 2 checks passed
@glensc glensc deleted the log-details branch July 31, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants