Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add build and push to ghcr similar to danger #1388

Merged
merged 1 commit into from Jul 29, 2023
Merged

Conversation

wilkyd
Copy link
Contributor

@wilkyd wilkyd commented Jul 29, 2023

Copy of danger/danger#1445 & 1446 fix for JS

@orta
Copy link
Member

orta commented Jul 29, 2023

Thanks

@orta orta merged commit 69e5062 into danger:main Jul 29, 2023
1 of 2 checks passed
@orta
Copy link
Member

orta commented Jul 29, 2023

I'm going to revert this as it is a breaking change - we were shipping to docker before and this removes that feature for people who were using it

I'm open to a version which ships to both, but not breaking folks' existing workflows

@wilkyd
Copy link
Contributor Author

wilkyd commented Jul 29, 2023

Not sure I understand, both the original workflow and the updated workflow seem to solely push the Docker image to the GitHub Container Registry (ghcr.io). I don't see any push to Docker Hub or other registries. Could you please specify the breaking change? Thanks

@orta
Copy link
Member

orta commented Jul 31, 2023

Hah, sorry, I misread the older build logs!

@wilkyd
Copy link
Contributor Author

wilkyd commented Jul 31, 2023

Thanks! We would now recommend folk to use the image (docker://ghcr.io/danger/danger:main) when it is released rather than danger/danger documented in the CI section. So something like:

jobs:
  my_first_job:
    steps:
      - name: My first step
        uses: docker://ghcr.io/danger/danger:main

I don't mind creating an official action in another repo with a tag input if it would make the usage clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants