New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make BitBucket Server username matching case insensitive #1291
Merged
orta
merged 1 commit into
danger:main
from
DavidBrunow:make_username_conditionals_case_insensitive
Jul 23, 2022
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -241,6 +241,49 @@ describe("API testing - BitBucket Server", () => { | |
]) | ||
}) | ||
|
||
it("getDangerCommentsCaseInsensitive", async () => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I added extra tests rather than changing the existing tests to have case differences in the usernames. I went this way to it is more obvious why the usernames don't match perfectly but I'm happy to make changes to go any other direction. |
||
const commitID = "e70f3d6468f61a4bef68c9e6eaba9166b096e23c" | ||
jsonResult = () => ({ | ||
isLastPage: true, | ||
values: [ | ||
{ | ||
comment: { | ||
text: `FAIL! danger-id-1; ${dangerSignaturePostfix({} as DangerResults, commitID)}`, | ||
author: { | ||
name: "userNAME", | ||
}, | ||
}, | ||
}, | ||
{ | ||
comment: null, | ||
}, | ||
{ | ||
comment: { | ||
text: "not a danger comment", | ||
author: { | ||
name: "azz", | ||
}, | ||
}, | ||
}, | ||
], | ||
}) | ||
const result = await api.getDangerComments("1") | ||
|
||
expect(api.fetch).toHaveBeenCalledWith( | ||
`${host}/rest/api/1.0/projects/FOO/repos/BAR/pull-requests/1/activities?fromType=COMMENT&start=0`, | ||
{ method: "GET", body: null, headers: expectedJSONHeaders }, | ||
undefined | ||
) | ||
expect(result).toEqual([ | ||
{ | ||
text: `FAIL! danger-id-1; ${dangerSignaturePostfix({} as DangerResults, commitID)}`, | ||
author: { | ||
name: "userNAME", | ||
}, | ||
}, | ||
]) | ||
}) | ||
|
||
it("getDangerInlineComments", async () => { | ||
jsonResult = () => ({ | ||
isLastPage: true, | ||
|
@@ -270,6 +313,35 @@ describe("API testing - BitBucket Server", () => { | |
expect(comments[0].ownedByDanger).toBeTruthy() | ||
}) | ||
|
||
it("getDangerInlineCommentsCaseInsensitive", async () => { | ||
jsonResult = () => ({ | ||
isLastPage: true, | ||
values: [ | ||
{ | ||
comment: { | ||
text: | ||
"\n[//]: # (danger-id-default;)\n[//]: # ( File: README.md;\n Line: 5;)\n\n- :warning: Hello updates\n\n\n ", | ||
author: { | ||
name: "userNAME", | ||
}, | ||
}, | ||
commentAnchor: { | ||
line: 5, | ||
lineType: "ADDED", | ||
}, | ||
}, | ||
], | ||
}) | ||
const comments = await api.getDangerInlineComments("default") | ||
expect(api.fetch).toHaveBeenCalledWith( | ||
`${host}/rest/api/1.0/projects/FOO/repos/BAR/pull-requests/1/activities?fromType=COMMENT&start=0`, | ||
{ method: "GET", body: null, headers: expectedJSONHeaders }, | ||
undefined | ||
) | ||
expect(comments.length).toEqual(1) | ||
expect(comments[0].ownedByDanger).toBeTruthy() | ||
}) | ||
|
||
it("getFileContents", async () => { | ||
textResult = "contents..." | ||
const result = await api.getFileContents("path/folder with space/foo.txt", "projects/FOO/repos/BAR", "master") | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure the history behind the
username ||
part of this code but it does not seem like the proper logic? Happy to revert removing it if I need to.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I can't figure it out either, so lets take it and see