Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Switch from tslint to eslint #1205

Merged
merged 4 commits into from Feb 2, 2022
Merged

chore: Switch from tslint to eslint #1205

merged 4 commits into from Feb 2, 2022

Commits on Feb 1, 2022

  1. chore: Switch from tslint to eslint 

    tslint is end-of-life, and warns when you install it. Additionally, the version we were on didn't support 'import type' expressions, as well as optional-chaining & null coalescing when I tried to use those in #1204

This PR does update a bunch of tslint-disable comments, but otherwise tries to minimally change runtime source in danger-js. If we want to tighten the eslint rules, I'd be super supportive, but I didn't want to cause a ton of thrash, so mostly the rules that are enabled are the ones that don't trigger on tons of existing code.
    @fbartho
    fbartho committed Feb 1, 2022
    Copy the full SHA
    3cee6a0 View commit details
    Browse the repository at this point in the history

  2. upgrade prettier + misc dangling TS issues

    @fbartho
    fbartho committed Feb 1, 2022
    Copy the full SHA
    bc614e7 View commit details
    Browse the repository at this point in the history

  3. Drop Support for Node v10 in AppVeyor CI

    @fbartho
    fbartho committed Feb 1, 2022
    Copy the full SHA
    b66f86f View commit details
    Browse the repository at this point in the history

  4. Update snapshot due to test-rename

    @fbartho
    fbartho committed Feb 1, 2022
    Copy the full SHA
    8322ffa View commit details
    Browse the repository at this point in the history