Add thread support for GitLab #1140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any activities here? I could need that one :O |
unfernandito
suggested changes
Nov 3, 2021
| this.repoMetadata.pullRequestID, | ||
| discussionId, | ||
| noteId, | ||
| // @ts-ignore |
There was a problem hiding this comment.
Hello Shym
I got a question, Why you need this ts-ignore here?
There is any cast issue with body property?
Comment on lines
+201
to
+202
| const { id: dangerUserId } = await this.api.getUser() | ||
| const threads = await this.api.getMergeRequestThreads(); |
There was a problem hiding this comment.
This could be resolved with Promise.all
Suggested change
| const { id: dangerUserId } = await this.api.getUser() | |
| const threads = await this.api.getMergeRequestThreads(); | |
| const [{ id: dangerUserId }, threads] = await Promise.all([this.api.getUser(), this.api.getMergeRequestThreads()]) |
Comment on lines
+103
to
+108
| await this.api.updateMergeRequestDiscussion(threads[0].id, threads[0].notes[0].id, newComment); | ||
| return `${this.api.mergeRequestURL}#note_${threads[0].notes[0].id}`; | ||
| } else { | ||
| const thread = await this.api.createMergeRequestDiscussion(newComment); | ||
|
|
||
| return `${this.api.mergeRequestURL}#note_${thread.notes[0].id}`; |
There was a problem hiding this comment.
Maybe the zero could be a const with a description. Looks like a magic number without any type of context of why the code should the zero index and not any other
| @@ -67,6 +67,14 @@ export class BitBucketCloud implements Platform { | |||
| return true | |||
| } | |||
|
|
|||
| supportsThreads() { | |||
|
pinging @shyim I hope you dont abandon this PR, its good work and I think the review comments are valid |
|
As it took me too long to have it. I just built something similar of Danger for our company. Free free to create a new PR based on this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That would be the way I would solve the thread problem.
After your Okay @orta I can implement also Github too :)