Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against dev version of keyring package #1116

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Test against dev version of keyring package #1116

merged 1 commit into from
Sep 15, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Sep 15, 2022

Closes #1113.

@jwodder jwodder added the tests Add or improve existing tests label Sep 15, 2022
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Base: 88.71% // Head: 88.67% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (3d700b8) compared to base (17e0b04).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1116      +/-   ##
==========================================
- Coverage   88.71%   88.67%   -0.05%     
==========================================
  Files          76       76              
  Lines        9119     9119              
==========================================
- Hits         8090     8086       -4     
- Misses       1029     1033       +4     
Flag Coverage Δ
unittests 88.67% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/dandiarchive.py 82.98% <0.00%> (-1.66%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic
Copy link
Member

Great, thank you!

@yarikoptic yarikoptic merged commit ae35684 into master Sep 15, 2022
@yarikoptic yarikoptic deleted the gh-1113 branch September 15, 2022 13:43
@github-actions
Copy link

🚀 PR was released in 0.46.3 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add keyring from github into -dev run of testing
2 participants