Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF(workaround): blacklist 23.9.0 of keyring since introduced regression #1112

Merged
merged 1 commit into from Sep 1, 2022

Conversation

yarikoptic
Copy link
Member

Closes #1111

Ref upstream: jaraco/keyring#593

@yarikoptic yarikoptic added release Create a release when this pr is merged internal Changes only affect the internal API labels Sep 1, 2022
Copy link
Member

@jwodder jwodder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update the conda-forge recipe after releasing!

@jwodder
Copy link
Member

jwodder commented Sep 1, 2022

On closer inspection, are you sure 23.8.2 is right version to exclude? That thread seems to say that 23.8.2 is the last good version and 23.9.0 is the problem.

@yarikoptic
Copy link
Member Author

On closer inspection, are you sure 23.8.2 is right version to exclude? That thread seems to say that 23.8.2 is the last good version and 23.9.0 is the problem.

d'oh, right, I rushed. I will fix to exclude 23.9.0

@yarikoptic yarikoptic changed the title BF(workaround): blacklist 23.8.2 of keyring since introduced regression BF(workaround): blacklist 23.9.0 of keyring since introduced regression Sep 1, 2022
@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #1112 (bf77fc9) into master (ef097cc) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1112      +/-   ##
==========================================
- Coverage   88.64%   88.55%   -0.09%     
==========================================
  Files          76       76              
  Lines        9108     9108              
==========================================
- Hits         8074     8066       -8     
- Misses       1034     1042       +8     
Flag Coverage Δ
unittests 88.55% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/conftest.py 52.94% <0.00%> (-47.06%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

🚀 PR was released in 0.46.2 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API release Create a release when this pr is merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: cannot import name 'properties' from 'keyring.util'
2 participants