Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly include "data packages" in project #1029

Merged
merged 1 commit into from Jun 27, 2022
Merged

Properly include "data packages" in project #1029

merged 1 commit into from Jun 27, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jun 9, 2022

There are several folders in dandi/ that contain data files but no Python source code, and we want these to be included when dandi is installed. Currently, these folders are automatically included by the combination of graft dandi in MANIFEST.in and include_package_data = True in setup.cfg, but because we set packages in setup.cfg to find: instead of find_namespace:, the folders themselves are not recognized by setuptools as packages. This combination of settings is deprecated, and the setuptools developers recommend using find_namespace: instead of find: for such situations.

@jwodder jwodder added the internal Changes only affect the internal API label Jun 9, 2022
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #1029 (3f655c5) into master (6d8c31e) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1029      +/-   ##
==========================================
+ Coverage   87.64%   87.68%   +0.04%     
==========================================
  Files          65       65              
  Lines        8261     8261              
==========================================
+ Hits         7240     7244       +4     
+ Misses       1021     1017       -4     
Flag Coverage Δ
unittests 87.68% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/support/threaded_walk.py 92.85% <0.00%> (-1.79%) ⬇️
dandi/_version.py 45.96% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d8c31e...3f655c5. Read the comment docs.

@yarikoptic yarikoptic merged commit 4d9e548 into master Jun 27, 2022
@yarikoptic yarikoptic deleted the data-pkg branch June 27, 2022 19:54
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

🚀 PR was released in 0.42.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants