Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keyring from github into -dev run of testing #1113

Closed
yarikoptic opened this issue Sep 2, 2022 · 2 comments · Fixed by #1116
Closed

Add keyring from github into -dev run of testing #1113

yarikoptic opened this issue Sep 2, 2022 · 2 comments · Fixed by #1116
Assignees
@jwodder
Labels
released

Comments

@yarikoptic
Copy link
Member

as done for nwbinspector at all in https://github.com/dandi/dandi-cli/pull/1108/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88R81

can't be done now since most recent release of keyring introduced regression and main is not yet fixed. A compatibility patch was suggested : jaraco/keyring#595
@yarikoptic yarikoptic added the blocked Blocked by some needed development/fix label Sep 2, 2022
@yarikoptic yarikoptic removed the blocked Blocked by some needed development/fix label Sep 14, 2022
@yarikoptic
Copy link
Member Author

I believe this issue was unblocked.

@jwodder jwodder mentioned this issue Sep 15, 2022
Merged
yarikoptic added a commit that referenced this issue Sep 15, 2022
@yarikoptic
Merge pull request #1116 from dandi/gh-1113
ae35684 
Test against dev version of keyring package
@github-actions
Copy link

🚀 Issue was released in 0.46.3 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwodder jwodder

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test against dev version of keyring package dandi/dandi-cli
2 participants
@yarikoptic @jwodder