Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rand dependency #45

Closed
wants to merge 1 commit into from
Closed

Conversation

chmln
Copy link
Contributor

@chmln chmln commented Aug 10, 2019

No description provided.

@dignifiedquire
Copy link
Contributor

Ping, any chance this getting merged? @hdevalence

@hdevalence
Copy link
Contributor

Hi there, I've been doing maintenance catchup this afternoon but I think I won't be able to get to looking at this one today. In general I think we want to align the rand_core dependency of x25519-dalek with that of curve25519-dalek, which is stuck due to semver requirements on the major version. However, it turns out that we got the Serde implementation wrong (dalek-cryptography/curve25519-dalek#265 (comment)) so I would like to do a 2.0.0 release, and that may make it possible to update.

@exrook
Copy link

exrook commented Nov 25, 2019

Any progress on this now that curve25519-dalek 2.0 is out?

@hdevalence
Copy link
Contributor

Yup, this is unblocked now, I'm expecting that there will be a new x25519 version with new rand this week.

@hdevalence hdevalence changed the base branch from master to develop November 26, 2019 20:53
@DebugSteven
Copy link
Collaborator

Thank you for writing this patch to update the rand_core version.
There were a couple of changes in order to get this work merged in and it has been incorporated into #52 with attribution. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants