Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed "nightly" from default features #34

Merged
merged 1 commit into from
Feb 4, 2019

Conversation

rozbb
Copy link
Collaborator

@rozbb rozbb commented Feb 3, 2019

I was using this crate and was surprised to have a compile error when switching to "stable". The error came from subtle trying to use a #![feature(...)] gate. I spent some time tracking down what was using subtle with the "nightly" feature flag set. I checked curve25519-dalek and ed25519-dalek and neither of them set "nightly" by default. I found it a bit surprising, then, that x25519-dalek was the culprit.

So, in keeping with curve25519-dalek, ed25519-dalek, subtle, and zkp, I think this should compile by default on "stable".

@hdevalence
Copy link
Contributor

This looks good, thanks! The CI failure seems unrelated to your changes and instead related to the usual rand brokenness (rust-random/rand#704)

@hdevalence hdevalence changed the base branch from master to develop February 4, 2019 20:30
@hdevalence hdevalence merged commit abff3dd into dalek-cryptography:develop Feb 4, 2019
@hdevalence
Copy link
Contributor

Released as 0.4.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants