Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ignored inline attributes from function prototypes #117

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oherrala
Copy link

@oherrala oherrala commented Nov 6, 2023

Attributes that are in function prototypes are ignored and emit a compiler warning. This pull request should not have any effect except removing the compiler warnings:

warning: `#[inline]` is ignored on function prototypes
   --> /Users/oherrala/.cargo/registry/src/index.crates.io-6f17d22bba15001f/subtle-2.5.0/src/lib.rs:282:5
    |
282 |     #[inline]
    |     ^^^^^^^^^
    |
    = note: `#[warn(unused_attributes)]` on by default

warning: `#[inline]` is ignored on function prototypes
   --> /Users/oherrala/.cargo/registry/src/index.crates.io-6f17d22bba15001f/subtle-2.5.0/src/lib.rs:425:5
    |
425 |     #[inline]
    |     ^^^^^^^^^

warning: `#[inline]` is ignored on function prototypes
   --> /Users/oherrala/.cargo/registry/src/index.crates.io-6f17d22bba15001f/subtle-2.5.0/src/lib.rs:612:5
    |
612 |     #[inline]
    |     ^^^^^^^^^

warning: `subtle` (lib) generated 3 warnings

Attributes that are in function prototypes are ignored and emit
compiler warning.
@AaronFeickert
Copy link

Might it be useful to keep the attributes as a helpful indication for implementers and silence the warnings, as in #121?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants