Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rand_core #68

Closed
wants to merge 1 commit into from
Closed

Use rand_core #68

wants to merge 1 commit into from

Conversation

newpavlov
Copy link
Contributor

rand crate is still used for thread RNG, but I think in future it will get splitted into a separate crate as well. Also I've fixed some of doctests for sha2 feature. (I think you should add it to CI)

@newpavlov newpavlov mentioned this pull request Jan 10, 2019
Closed
@newpavlov newpavlov mentioned this pull request Jan 25, 2019
Closed
@newpavlov
Copy link
Contributor Author

Conflicts are too confusing, so I think it will be easier to redo this PR from scratch. :/

Also note that rand project has plans for the next breaking version, which may result in a breaking change for rand_core.

@newpavlov
Copy link
Contributor Author

Current code uses ThreadRng in verify_batch, which right now is only accessible via rand. I could replace it with rand_os, but performance will be a bit worse in result.

So I guess it will be better to postpone these changes until rand v0.7 is released.

@newpavlov newpavlov closed this Mar 20, 2019
@newpavlov newpavlov deleted the rand_core branch March 20, 2019 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isislovecruft isislovecruft isislovecruft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@newpavlov @isislovecruft