Add VerifyingKey::to_edwards #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
reviewed
Feb 12, 2024
|
I assume the original reason for not having these was so |
|
Hmm, an unrelated failure due to new nightly lints for a debugging trait which needs to get annotated with Edit: opened #625 |
|
@randombit #625 is merged. If you rebase it should fix the test failure |
Adds VerifyingKey::to_edwards and a From conversion See dalek-cryptography#623
randombit
force-pushed
the
jack/to-edwards
branch
from
fae7a4f
to
d99a73b
Compare
|
Rebased with #625 |
|
Thank you! |
mikelodder7
pushed a commit
to mikelodder7/curve25519-dalek-ml
that referenced
this pull request
Feb 17, 2024
…dalek-cryptography#624) Adds VerifyingKey::to_edwards and a From conversion See dalek-cryptography#623
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #623