Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address clippy lints #543

Merged
merged 1 commit into from Aug 27, 2023
Merged

Address clippy lints #543

merged 1 commit into from Aug 27, 2023

Conversation

robjtede
Copy link
Contributor

@robjtede robjtede commented Jul 2, 2023

No description provided.

@robjtede robjtede force-pushed the rclippy branch 5 times, most recently from e641178 to f941994 Compare July 30, 2023 13:44
@robjtede robjtede mentioned this pull request Jul 30, 2023
Closed
@pinkforest
Copy link
Contributor

pinkforest commented Aug 8, 2023 •
edited

@robjtede thanks 😅 EDIT: lgtm 🎉

Could we also include --all-features as well in:
https://github.com/dalek-cryptography/curve25519-dalek/blob/main/.github/workflows/workspace.yml#L68

@robjtede robjtede mentioned this pull request Aug 11, 2023
Merged
@robjtede
Copy link
Contributor Author

@pinkforest bump on this since it LG now

@robjtede
Copy link
Contributor Author

robjtede commented Aug 27, 2023 •
edited

bump; this an easy enough merge

tarcieri
tarcieri approved these changes Aug 27, 2023
View reviewed changes
Copy link
Contributor

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might suggest disabling clippy::needless_range_loop but this is otherwise fine

@tarcieri tarcieri merged commit b93ace8 into dalek-cryptography:main Aug 27, 2023
23 checks passed
@robjtede robjtede deleted the rclippy branch August 27, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri tarcieri approved these changes

@dconnolly dconnolly dconnolly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@robjtede @pinkforest @tarcieri @dconnolly