Expand lints #530
Merged
Expand lints #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
commented
Jun 12, 2023
tarcieri
commented
Jun 12, 2023
tarcieri
force-pushed
the
expand-lints
branch
2 times, most recently
from
0861285
to
22fc914
Compare
Adds a lints section to the top of lib.rs with the following:
#![warn(
clippy::unwrap_used,
missing_docs,
rust_2018_idioms,
unused_lifetimes,
unused_qualifications
)]
`warn` is used instead of `deny` to prevent the lints from firing during
local development, however we already configure `-D warnings` in CI so
if any lint fails on checked-in code, it will cause a CI failure.
This commit also fixes or explicitly allows any current violations of
these lints. The main ones were:
- `clippy::unwrap_used`: replaces usages of `unwrap` with `expect`
- `rust_2018_idioms`: no implicit lifetimes, which were present on
usages of `core::fmt::Formatter`
robjtede
approved these changes
Aug 27, 2023
|
These are all good lints imo. Ty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a lints section to the top of lib.rs with the following:
warnis used instead ofdenyto prevent the lints from firing during local development, however we already configure-D warningsin CI so if any lint fails on checked-in code, it will cause a CI failure.This commit also fixes or explicitly allows any current violations of these lints. The main ones were:
clippy::unwrap_used: replaces usages ofunwrapwithexpectrust_2018_idioms: no implicit lifetimes, which were present on usages ofcore::fmt::Formatterunused_lifetimes: corrects a few instances