Replace unwrap_u8 with into
#528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leverages the `From<Choice>` impl for `bool` where applicable instead, which results in clearer logic which more closely matches `bool`.
tarcieri
force-pushed
the
remove-unwrap_u8
branch
from
d0fc864
to
0ab2281
Compare
rozbb
reviewed
May 30, 2023
src/ristretto.rs
Outdated
| || t.is_negative().unwrap_u8() == 1u8 | ||
| || y.is_zero().unwrap_u8() == 1u8 | ||
| { | ||
| if (!ok).into() || t.is_negative().into() || y.is_zero().into() { |
There was a problem hiding this comment.
Probably not an issue, but might be better to phrase this as:
if bool::from(!ok | t.is_negative() | y.is_zero()) {There was a problem hiding this comment.
Pushed up a slightly different version in 32893c3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leverages the
From<Choice>impl forboolwhere applicable instead, which results in clearer logic which more closely matchesbool.