Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the equality of EdwardsPoints in the projective coordinates #226

Merged
merged 1 commit into from May 21, 2019

Conversation

ebfull
Copy link
Contributor

@ebfull ebfull commented Jan 23, 2019

I stumbled on this sentence at ristretto.group:

Equality testing of points on the Edwards curve requires comparing to affine coordinates, which requires an expensive inversion. However, testing whether two points lie in the same coset can be done in projective coordinates, making it actually easier than equality testing in the original non-quotient group.

which led me to check the code here and notice this could be optimized. 😺

@ebfull
Copy link
Contributor Author

ebfull commented Jan 23, 2019

Test failures are unrelated to this PR I think.

@hdevalence
Copy link
Contributor

Looks like the build failure is related to rust-random/rand#702

@hdevalence hdevalence added this to the 1.2 milestone Feb 15, 2019
@ebfull
Copy link
Contributor Author

ebfull commented Mar 21, 2019

Note that the current implementation of is_small_order seems to invoke this to compare against the identity, requiring several inversions.

Copy link
Contributor

@hdevalence hdevalence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants