Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix same custom sections #77

Merged
merged 1 commit into from Jul 14, 2022
Merged

fix same custom sections #77

merged 1 commit into from Jul 14, 2022

Conversation

daixiang0
Copy link
Owner

Signed-off-by: Loong Dai loong.dai@intel.com

Signed-off-by: Loong Dai <loong.dai@intel.com>
@daixiang0
Copy link
Owner Author

Fix issue reported from @ttys3

@daixiang0 daixiang0 merged commit cb206ae into master Jul 14, 2022
@daixiang0 daixiang0 deleted the fix-same-prefix branch July 14, 2022 13:36
@ttys3
Copy link

ttys3 commented Jul 14, 2022

just tested cb206ae
the order is back to normal

but still a small problem: newline after one line import will be stripped

for example:

input:

package svc

import "google.golang.org/protobuf/proto"

// GetFoo do things
func GetFoo() {
  // body
}

buggy output (the newline after import "google.golang.org/protobuf/proto" is gone):

package svc

import "google.golang.org/protobuf/proto"
// GetFoo do things
func GetFoo() {
  // body
}

@daixiang0
Copy link
Owner Author

I also notice it and will fix it today :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants