Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests and fixes #39

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Tests and fixes #39

wants to merge 8 commits into from

Commits on Sep 3, 2021

  1. chore: re-generate with Go 1.17 

    Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
    @LukeShu
    LukeShu committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    8c845a0 View commit details
    Browse the repository at this point in the history

  2. fix: README.md: Remove obsolete TODO item 

    I implemented this in daixiang0#33 but forgot to update README.md

Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
    @LukeShu
    LukeShu committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    8d1bff7 View commit details
    Browse the repository at this point in the history

  3. tests: add tests based on the examples in README.md 

    Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
    @LukeShu
    LukeShu committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    9382acb View commit details
    Browse the repository at this point in the history

  4. fix: handling of whitespace between import-spec components 

    Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
    @LukeShu
    LukeShu committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    485f559 View commit details
    Browse the repository at this point in the history

  5. style: use a 'PkgType' type instead of just an int 

    Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
    @LukeShu
    LukeShu committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    0797283 View commit details
    Browse the repository at this point in the history

  6. fix: don't insert an extra newline for leading comments 

    Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
    @LukeShu
    LukeShu committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    015719d View commit details
    Browse the repository at this point in the history

  7. fix: don't mangle comments with "//" in them 

    Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
    @LukeShu
    LukeShu committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    2981cd6 View commit details
    Browse the repository at this point in the history

  8. fix: don't interfere with others' notions of whitespace 

    For instance, it's style with nolintlint to not have a space between the
"//" and the "nolint:", yet gci puts a space there.  Let other linters
worry about whitespace, gci is for import order.

Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
    @LukeShu
    LukeShu committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    6dae7fe View commit details
    Browse the repository at this point in the history