Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix out of range panics #182

Merged
merged 1 commit into from Feb 19, 2024
Merged

Conversation

dnovikoff
Copy link
Contributor

If the input is an incorrectly sorted list of imports, and the file consist only of import section not followed by a newline, the code panics with makeslice: len out of range

Signed-off-by: Dmitry Novikov <novikov.dmitri.a@gmail.com>
@daixiang0 daixiang0 merged commit 5ae85f3 into daixiang0:master Feb 19, 2024
7 checks passed
@daixiang0
Copy link
Owner

@dnovikoff thanks for your contribution!

codeboten added a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Mar 14, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/daixiang0/gci](https://togithub.com/daixiang0/gci) |
`v0.12.1` -> `v0.12.3` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fdaixiang0%2fgci/v0.12.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fdaixiang0%2fgci/v0.12.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fdaixiang0%2fgci/v0.12.1/v0.12.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fdaixiang0%2fgci/v0.12.1/v0.12.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>daixiang0/gci (github.com/daixiang0/gci)</summary>

### [`v0.12.3`](https://togithub.com/daixiang0/gci/releases/tag/v0.12.3)

[Compare
Source](https://togithub.com/daixiang0/gci/compare/v0.12.2...v0.12.3)

#### What's Changed

- bump up to 0.12.3 by
[@&#8203;daixiang0](https://togithub.com/daixiang0) in
[daixiang0/gci#188

**Full Changelog**:
daixiang0/gci@v0.12.2...v0.12.3

### [`v0.12.2`](https://togithub.com/daixiang0/gci/releases/tag/v0.12.2)

[Compare
Source](https://togithub.com/daixiang0/gci/compare/v0.12.1...v0.12.2)

#### What's Changed

- Update standard library list for go1.22.0 by
[@&#8203;ebati](https://togithub.com/ebati) in
[daixiang0/gci#186
- Fix out of range panics by
[@&#8203;dnovikoff](https://togithub.com/dnovikoff) in
[daixiang0/gci#182

#### New Contributors

- [@&#8203;ebati](https://togithub.com/ebati) made their first
contribution in
[daixiang0/gci#186
- [@&#8203;dnovikoff](https://togithub.com/dnovikoff) made their first
contribution in
[daixiang0/gci#182

**Full Changelog**:
daixiang0/gci@v0.12.1...v0.12.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants