Fix line endings for CRLF (windows) #170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SvenGasterstaedt
force-pushed
the
master
branch
3 times, most recently
from
f0e9777
to
ecd4e10
Compare
Signed-off-by: Sven Gasterstädt <131267808+SvenGasterstaedt@users.noreply.github.com>
SvenGasterstaedt
force-pushed
the
master
branch
from
ecd4e10
to
b65845b
Compare
|
@SvenGasterstaedt all format is based on UNIX, what do you mean common config not work? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix line endings for windows.
Currently the replacing of line endings is wrong and too late. Rather than replacing "\r\n" which represents a windows line ending only "\r" is replaced resulting in double line endings on files with CRLF-endings.
Unfortunalty just adjusting the replacement from "\r" to "\r\n" breaks the formatting as the parser above also depends on UNIX-lineendings.
TODO: