Skip to content

Commit

Permalink
Add short func with named return (gin-gonic#2837)
Browse files Browse the repository at this point in the history
  • Loading branch information
sashamelentyev authored and daheige committed Apr 18, 2022
1 parent 700a09b commit a770bd0
Showing 1 changed file with 24 additions and 28 deletions.
52 changes: 24 additions & 28 deletions context.go
Expand Up @@ -391,9 +391,9 @@ func (c *Context) Param(key string) string {
// c.Query("name") == "Manu"
// c.Query("value") == ""
// c.Query("wtf") == ""
func (c *Context) Query(key string) string {
value, _ := c.GetQuery(key)
return value
func (c *Context) Query(key string) (value string) {
value, _ = c.GetQuery(key)
return
}

// DefaultQuery returns the keyed url query value if it exists,
Expand Down Expand Up @@ -427,9 +427,9 @@ func (c *Context) GetQuery(key string) (string, bool) {

// QueryArray returns a slice of strings for a given query key.
// The length of the slice depends on the number of params with the given key.
func (c *Context) QueryArray(key string) []string {
values, _ := c.GetQueryArray(key)
return values
func (c *Context) QueryArray(key string) (values []string) {
values, _ = c.GetQueryArray(key)
return
}

func (c *Context) initQueryCache() {
Expand All @@ -444,18 +444,16 @@ func (c *Context) initQueryCache() {

// GetQueryArray returns a slice of strings for a given query key, plus
// a boolean value whether at least one value exists for the given key.
func (c *Context) GetQueryArray(key string) ([]string, bool) {
func (c *Context) GetQueryArray(key string) (values []string, ok bool) {
c.initQueryCache()
if values, ok := c.queryCache[key]; ok && len(values) > 0 {
return values, true
}
return []string{}, false
values, ok = c.queryCache[key]
return
}

// QueryMap returns a map for a given query key.
func (c *Context) QueryMap(key string) map[string]string {
dicts, _ := c.GetQueryMap(key)
return dicts
func (c *Context) QueryMap(key string) (dicts map[string]string) {
dicts, _ = c.GetQueryMap(key)
return
}

// GetQueryMap returns a map for a given query key, plus a boolean value
Expand All @@ -467,9 +465,9 @@ func (c *Context) GetQueryMap(key string) (map[string]string, bool) {

// PostForm returns the specified key from a POST urlencoded form or multipart form
// when it exists, otherwise it returns an empty string `("")`.
func (c *Context) PostForm(key string) string {
value, _ := c.GetPostForm(key)
return value
func (c *Context) PostForm(key string) (value string) {
value, _ = c.GetPostForm(key)
return
}

// DefaultPostForm returns the specified key from a POST urlencoded form or multipart form
Expand Down Expand Up @@ -498,9 +496,9 @@ func (c *Context) GetPostForm(key string) (string, bool) {

// PostFormArray returns a slice of strings for a given form key.
// The length of the slice depends on the number of params with the given key.
func (c *Context) PostFormArray(key string) []string {
values, _ := c.GetPostFormArray(key)
return values
func (c *Context) PostFormArray(key string) (values []string) {
values, _ = c.GetPostFormArray(key)
return
}

func (c *Context) initFormCache() {
Expand All @@ -518,18 +516,16 @@ func (c *Context) initFormCache() {

// GetPostFormArray returns a slice of strings for a given form key, plus
// a boolean value whether at least one value exists for the given key.
func (c *Context) GetPostFormArray(key string) ([]string, bool) {
func (c *Context) GetPostFormArray(key string) (values []string, ok bool) {
c.initFormCache()
if values := c.formCache[key]; len(values) > 0 {
return values, true
}
return []string{}, false
values, ok = c.formCache[key]
return
}

// PostFormMap returns a map for a given form key.
func (c *Context) PostFormMap(key string) map[string]string {
dicts, _ := c.GetPostFormMap(key)
return dicts
func (c *Context) PostFormMap(key string) (dicts map[string]string) {
dicts, _ = c.GetPostFormMap(key)
return
}

// GetPostFormMap returns a map for a given form key, plus a boolean value
Expand Down

0 comments on commit a770bd0

Please sign in to comment.