Add an "initial_jitter_seconds" field to DagsterDaemon #21789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmsanders
approved these changes
May 10, 2024
| self.interval_seconds = check.numeric_param(interval_seconds, "interval_seconds") | ||
| self.jitter_seconds = jitter_seconds | ||
| self.interval_jitter_seconds = interval_jitter_seconds | ||
| self.initial_jitter_seconds = initial_jitter_seconds |
There was a problem hiding this comment.
startup_jitter_seconds? Just because interval and initial read so similarly when skimming.
Summary: Allows daemons to be configured in such a way that they do not all hammer the DB simultaneously on startup Test Plan: See corresponding internal PR
nikomancy
pushed a commit
that referenced
this pull request
May 22, 2024
Summary: Allows daemons to be configured in such a way that they do not all hammer the DB simultaneously on startup Test Plan: See corresponding internal PR ## Summary & Motivation ## How I Tested These Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Allows daemons to be configured in such a way that they do not all hammer the DB simultaneously on startup
Test Plan: See corresponding internal PR
Summary & Motivation
How I Tested These Changes