Minimize workspace snapshot dependency from GrapheneAssetLatestInfo #21764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The medium term plan here is to have GrapheneAssetNode be the field that requires definition-level data, and the imperfectly named GrapheneAssetLatestInfo to handle all the fields that require access to the In the short-term, we still need the nodes in the case where the most recent run for that asset is in progress. But that should still be a visible improvement over fetching the nodes for every asset on every query.
gibsondan
force-pushed
the
assetslatestinfoid
branch
from
870fe0b
to
d05b1cc
Compare
OwenKephart
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The medium term plan here is to have GrapheneAssetNode be the field that requires definition-level data, and the imperfectly named GrapheneAssetLatestInfo to handle all the fields that require access to the
In the short-term, we still need the nodes in the case where the most recent run for that asset is in progress. But that should still be a visible improvement over fetching the nodes for every asset on every query.
Summary & Motivation
How I Tested These Changes