Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[du] full sending on type annotations #21726

Merged
merged 2 commits into from May 13, 2024

Conversation

tacastillo
Copy link
Contributor

Summary & Motivation

How I Tested These Changes

Copy link
Contributor Author

tacastillo commented May 8, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tacastillo and the rest of your teammates on Graphite Graphite

@tacastillo tacastillo marked this pull request as ready for review May 8, 2024 17:22
@graphite-app graphite-app bot added the area: dagster-university Related to Dagster University label May 8, 2024
Copy link

github-actions bot commented May 8, 2024

Deploy preview for dagster-university ready!

✅ Preview
https://dagster-university-6sklpe1op-elementl.vercel.app
https://05-08--du-full-sending-on-type-annotations.dagster-university.dagster-docs.io

Built with commit 13aba55.
This pull request is being automatically deployed with vercel-action

Copy link
Contributor

@erinkcochran87 erinkcochran87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment but otherwise lgtm

Copy link

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-ct1xf81vw-elementl.vercel.app
https://05-08--du-full-sending-on-type-annotations.dagster.dagster-docs.io

Direct link to changed pages:

Copy link
Contributor Author

tacastillo commented May 13, 2024

Merge activity

  • May 13, 1:34 PM EDT: @tacastillo started a stack merge that includes this pull request via Graphite.
  • May 13, 1:38 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 13, 1:39 PM EDT: @tacastillo merged this pull request with Graphite.

@tacastillo tacastillo force-pushed the 05-08-_du_updating_based_on_api_changes_from_1dot7 branch from 73e96b1 to bf879b5 Compare May 13, 2024 17:35
Base automatically changed from 05-08-_du_updating_based_on_api_changes_from_1dot7 to master May 13, 2024 17:37
@tacastillo tacastillo force-pushed the 05-08-_du_full_sending_on_type_annotations branch from b69af83 to 3d211ef Compare May 13, 2024 17:37
@tacastillo tacastillo merged commit 7351009 into master May 13, 2024
0 of 2 checks passed
@tacastillo tacastillo deleted the 05-08-_du_full_sending_on_type_annotations branch May 13, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dagster-university Related to Dagster University
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants