New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] - Improve Pipes API docs #21707
Conversation
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-2t3wjignt-elementl.vercel.app Direct link to changed pages: |
Important to note that:
They are two different use cases targeted to different personas. The "platform owner" more likely to be working on and setting up clients; the "pipeline builder" will be including So while the previous organization wasn't ideal merging all the pipes client stuff (which is much more complex) with |
Also heads up that I'm fixing pipes docs issues: #21719 |
@schrockn Heard. Took another swing at this - basically left all the formatting, but moved things back to their separate pages and beefed up the intros. I called out exactly where the APIs in the reference should be used and added callouts for users who may be looking for the other reference. For example, I added this to the page for
Updated Updated Dagster Pipes reference: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking much better! My final recommendation is that we further subdivide docs into 1) stuff that people need to know if they are consuming an integration versus 2) people building a new integration (much more advanced)
|
||
.. currentmodule:: dagster_pipes | ||
|
||
The ``dagster-pipes`` library is intended for inclusion in an external process that integrates with Dagster using the `Pipes </concepts/dagster-pipes>`_ protocol. This could be in an environment like Databricks, Kubernetes, or Docker. Using this library, you can write code in the external process that streams metadata back to Dagster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can also mention that pipes passes parameters to the external process from the orchestration environment and you can access them there. It's a key value prop of the system.
Re-requesting to get back in queue
@schrockn Made the changes you asked for! Let me know if you have specific wording in mind and I'll make the updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Please heed final comment. 馃檹馃徎
Summary & Motivation
This PR adds information to the Pipes and
dagster-pipes
API references to clarify where and how each set of APIs should be used. Previously, the introductions for these references were vague and confusing - it was difficult to tell which set of APIs you needed and when.I've also added broken the APIs up into sections, grouped by type, and added information about what each group does. I've also added links to appropriate guides to make cross-referencing content easier.
After:
Preview links: Dagster Pipes reference;
dagster-pipes
referenceBefore:
How I Tested These Changes
馃憖 , local