Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Deploy todoapp with dev dagger AND ALSO latest 0.2.x release #2172

Merged

Conversation

gerhard
Copy link
Member

@gerhard gerhard commented Apr 13, 2022

Thanks to a great community contribution, we are improving the GitHub Actions integration further. We should probably do the same for the GitLab integration doc as a follow-up to this.

This should be merged after #1962. Maybe @ekinbarut wants to take a look at it 馃憢馃徎

@gerhard gerhard requested a review from a team as a code owner April 13, 2022 13:32
@gerhard gerhard requested a review from aluzzardi April 13, 2022 13:37
@gerhard

This comment was marked as outdated.

@gerhard
Copy link
Member Author

gerhard commented Apr 13, 2022

Adding @aluzzardi as a reviewer since this introduces a new testing pattern: dev AND latest release.

This will become increasingly important as we start thinking about 0.3 pre-releases in the context of 0.2 -> 0.3.

While 0.1 -> 0.2 was a one off, I don't expect us to do the same with 0.3.

@gerhard

This comment was marked as resolved.

@gerhard gerhard force-pushed the test-todoapp-with-latest-stable-dagger-release branch 2 times, most recently from 7ed7638 to 9d43273 Compare April 13, 2022 13:50
@gerhard
Copy link
Member Author

gerhard commented Apr 13, 2022

Question for @dagger/maintainers: should multiple areas be appended to a commit that introduces multiple changes, e.g. docs: ci:. This one would most certainly qualify as such.

@gerhard

This comment was marked as outdated.

@gerhard

This comment was marked as outdated.

@gerhard

This comment was marked as resolved.

@gerhard gerhard changed the title Deploy todoapp with dev dagger AND ALSO latest 0.2.x release docs: ci: Deploy todoapp with dev dagger AND ALSO latest 0.2.x release Apr 14, 2022
@gerhard gerhard changed the title docs: ci: Deploy todoapp with dev dagger AND ALSO latest 0.2.x release ci: docs: Deploy todoapp with dev dagger AND ALSO latest 0.2.x release Apr 14, 2022
Copy link
Member

@TomChv TomChv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great improvement, I like that one :D

@TomChv
Copy link
Member

TomChv commented Apr 14, 2022

Question for https://github.com/orgs/dagger/teams/maintainers: should multiple areas be appended to a commit that introduces multiple changes, e.g. docs: ci:. This one would most certainly qualify as such.

There shouldn't be multiple change.
If you update doc then commit with docs, if you update ci then it should be ci
If you do both, then there should be two commits or ignore less important.

In your case, I think you could ignore docs or do it in another PR :D

@gerhard
Copy link
Member Author

gerhard commented Apr 14, 2022

Thank you @TomChv!

Need to add changes from #2195 before merging.

@gerhard gerhard changed the title ci: docs: Deploy todoapp with dev dagger AND ALSO latest 0.2.x release ci: Deploy todoapp with dev dagger AND ALSO latest 0.2.x release Apr 14, 2022
@gerhard gerhard removed the area/documentation Improvements or additions to documentation label Apr 14, 2022
@TomChv
Copy link
Member

TomChv commented Apr 14, 2022

Why your commit is prefixed with docs: but your CI is prefixed with ci:?

@gerhard
Copy link
Member Author

gerhard commented Apr 14, 2022

Why your commit is prefixed with docs: but your CI is prefixed with ci:?

It is a ci: change. Fixing it now, together with #2195 馃檪

@gerhard gerhard force-pushed the test-todoapp-with-latest-stable-dagger-release branch from 9d43273 to 4d12f8d Compare April 14, 2022 17:36
Thanks to a great community contribution, we are improving the GitHub
Actions integration further. We should probably do the same for the
GitLab integration doc as a follow-up to this.

Follow-up to dagger#1962
Uses improvements from dagger#2195

Signed-off-by: Gerhard Lazu <gerhard@lazu.co.uk>
@gerhard gerhard force-pushed the test-todoapp-with-latest-stable-dagger-release branch from 4d12f8d to d5ffae2 Compare April 14, 2022 17:41
@gerhard
Copy link
Member Author

gerhard commented Apr 14, 2022

@gerhard gerhard merged commit b6c3f91 into dagger:main Apr 14, 2022
@gerhard gerhard deleted the test-todoapp-with-latest-stable-dagger-release branch April 14, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants