-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Deploy todoapp with dev dagger AND ALSO latest 0.2.x release #2172
ci: Deploy todoapp with dev dagger AND ALSO latest 0.2.x release #2172
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Adding @aluzzardi as a reviewer since this introduces a new testing pattern: dev AND latest release. This will become increasingly important as we start thinking about 0.3 pre-releases in the context of 0.2 -> 0.3. While 0.1 -> 0.2 was a one off, I don't expect us to do the same with 0.3. |
This comment was marked as resolved.
This comment was marked as resolved.
7ed7638
to
9d43273
Compare
Question for @dagger/maintainers: should multiple areas be appended to a commit that introduces multiple changes, e.g. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great improvement, I like that one :D
There shouldn't be multiple change. In your case, I think you could ignore |
Why your commit is prefixed with |
It is a |
9d43273
to
4d12f8d
Compare
Thanks to a great community contribution, we are improving the GitHub Actions integration further. We should probably do the same for the GitLab integration doc as a follow-up to this. Follow-up to dagger#1962 Uses improvements from dagger#2195 Signed-off-by: Gerhard Lazu <gerhard@lazu.co.uk>
4d12f8d
to
d5ffae2
Compare
Thanks to a great community contribution, we are improving the GitHub Actions integration further. We should probably do the same for the GitLab integration doc as a follow-up to this.
This should be merged after #1962. Maybe @ekinbarut wants to take a look at it 馃憢馃徎