Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade deps #68

Closed
wants to merge 1 commit into from
Closed

Conversation

zaibon
Copy link

@zaibon zaibon commented Aug 29, 2023

Upgrade dependencies to the latest versions.
This solves the issue with the deprecation of the set-env function from GitHub Actions.

@daaku
Copy link
Owner

daaku commented Aug 30, 2023

Hi, thanks for this PR. In debugging the failed action I decided to replace node with bash.

If possible, try PR #69 and let me know if it works for you. I'm not using this any longer, but the minimal test seems to indicate things are still working as intended.

@zaibon
Copy link
Author

zaibon commented Aug 30, 2023

I also struggled a bit to get the action to pass, but I managed to do it by using an older version of node. You can see the commit that solved the problem at zaibon@2ff4ebe

@daaku
Copy link
Owner

daaku commented Aug 30, 2023

Ah, I wonder why that didn't reflect in the run on this PR here. In any case, I can wait for you to test PR #69 or merge it and you can test it after it's tagged?

@daaku
Copy link
Owner

daaku commented Aug 30, 2023

I've tested that version tagged v2.0.1 and it seems good.

@daaku daaku closed this Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants