Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit sentence to fix potential typo and for consistency #3780

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

sensologica
Copy link
Contributor

I believe that the word should have been "radians", not "radius". Instead of fixing this (potential) typo, however, maybe deleting this part of the sentence altogether is the better option? Deleting it makes the arc.startAngle(angle) description match the arc.endAngle(angle) description (which does not mention radius/radians in the corresponding sentence). Radians are addressed elsewhere, so mentioning them in the edited sentence is, perhaps, not necessary.

I believe that the word should have been "radians", not "radius". Instead of fixing this (potential) typo, however, maybe deleting this part of the sentence altogether is the better option? Deleting it makes the `arc.startAngle(angle)` description match the `arc.endAngle(angle)` description (which does not mention radius/radians in the corresponding sentence). Radians are addressed elsewhere, so mentioning them in the edited sentence is, perhaps, not necessary.
@mbostock
Copy link
Member

Yes, it was intended to be “radians”.

@Fil Fil enabled auto-merge (squash) October 30, 2023 14:41
@Fil Fil merged commit 6e37f0a into d3:main Oct 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants