Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single module #3773

Merged
merged 3 commits into from
Oct 5, 2023
Merged

single module #3773

merged 3 commits into from
Oct 5, 2023

Conversation

Fil
Copy link
Member

@Fil Fil commented Oct 5, 2023

add an example of how to load from a single module (using the recommended ESM method & destructuring)

@Fil Fil requested a review from mbostock October 5, 2023 16:43
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a separate example rather than part of the existing group because it is not functionally equivalent like the other tabs are. I would add some preamble context like “you can also import individual D3 modules like so”.

Other notes:

  • Use a major version number when loading d3-force
  • Blank lines at the start and end of the script
  • No two spaces of indentation for the script
  • Use four spaces of indentation for chaining

@Fil Fil enabled auto-merge (squash) October 5, 2023 19:24
@Fil Fil merged commit e4682f1 into main Oct 5, 2023
1 check passed
@Fil Fil deleted the fil/import-module branch October 5, 2023 19:25
@Fil
Copy link
Member Author

Fil commented Oct 5, 2023

Oops this auto-merged without your approval! I forgot that the rules are different here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants