Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve docs on modules #3319

Closed
wants to merge 1 commit into from
Closed

improve docs on modules #3319

wants to merge 1 commit into from

Conversation

stevemao
Copy link

No description provided.

Copy link

@ux-engineer ux-engineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice pointer... But do you mean that CommonJS is not tree-shakeable? For that there would be https://github.com/indutny/webpack-common-shake

@stevemao
Copy link
Author

@envision thanks!, I'd reword it to: NOTE: This will bundle every module in D3

To try to avoid mentioning tree shaking.

@milospanasiuk
Copy link

Hello there,

Can someone guide on how to update the wiki with an additional plugin link? Tried various solutions but none was successful.
When creating a pull request, the wiki is not detected from forked repo since its repo for itself.

@curran
Copy link
Contributor

curran commented Jun 13, 2019

@milospanasiuk I believe the wiki was locked as a result of abuse/spam. Take a look at the age of the entries there, they are all quite old now.

This may be the closest replacement for listing plugins/packages: https://github.com/wbkd/awesome-d3

@mbostock
Copy link
Member

mbostock commented Aug 1, 2019

Thank you for the suggestion. The behavior of tree-shaking is dependent on the bundler you are using; for example Rollup does tree-shaking fairly intelligently using static analysis. Also, tree-shaking may be affected by adoption of the sideEffects flag #3131

While I know this PR is well-intentioned, I do not want to take responsibility for documenting how bundlers behave. People should refer to their preferred bundler’s documentation instead.

@mbostock mbostock closed this Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants