strike interpolateNumber from transition docs #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per #67, it looks like
interpolateNumber
is never invoked, because all values are coerced to string first.The proposal is to bring the documentation in sync with the implementation.
If this proposal is correct, then the first case could probably be dropped from
src/transition/interpolate.js
Background: I want to understand why the behavior of some transitions changed when porting dc.js from d3v3 to d3v4. Previously if an attribute was not set on enter but was set in the transition, it took the final value with no animation. Now it starts from zero.
It's our bug and we need to fix it. We were relying on undefined behavior and it's better to be explicit about where you transition from. But, I still want to understand what changed.
I found this SO question:
https://stackoverflow.com/questions/47339762/what-attributes-does-d3-transition-change
Which referenced this comment: #67 (comment)
I'm not sure if this change in implementation explains the change in observed behavior, but as noted, it's not a real problem.
(edited for clarity)