add utcMonthDay, timeMonthDay #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We also need to delete the README here and point to the new documentation on d3js.org, and update the documentation there… I’ll do that separately. |
Fil
approved these changes
Jun 26, 2023
|
Broader discussion in #64, wherein I think we should consider changing the behavior of interval.every universally. The main wrinkle is d3.timeHour and daylight savings time… Also, arguably, the design of D3’s “multi-scale” tick format, but I think that becomes less important now that we have a better strategy for time axes in Observable Plot. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62.
I think it’s proven pretty surprising that d3.utcDay.every(3) is not regularly spaced, so better to match d3.utcDay behave the way people expect, and have d3.utcMonthDay for the month-aligned day interval. Same goes for d3.timeDay, and now we don’t need the awkwardly named d3.unixDay (though I’ll keep it as a deprecated alias for backwards compatibility).