Limit the number of iterations in scaleLinear.nice

d3 · May 20, 2020 · 96b8f4b · 96b8f4b
1 parent 694ed8f
commit 96b8f4b
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/linear.js b/src/linear.js
@@ -26,14 +26,14 @@ export function linearish(scale) {
     let stop = d[i1];
     let prestep;
     let step;
+    let maxIter = 10;
 
     if (stop < start) {
       step = start, start = stop, stop = step;
       step = i0, i0 = i1, i1 = step;
     }
 
-    // eslint-disable-next-line no-constant-condition
-    while (true) {
+    while (maxIter-- > 0) {
       const step = tickIncrement(start, stop, count);
       if (step === prestep) {
         d[i0] = start
@@ -46,10 +46,12 @@ export function linearish(scale) {
         start = Math.ceil(start * step) / step;
         stop = Math.floor(stop * step) / step;
       } else {
-        return scale;
+        break;
       }
       prestep = step;
     }
+
+    return scale;
   };
 
   return scale;