interpolateNumberArray #77

Fil · 2019-11-19T18:46:50Z

interpolates typed arrays (Float64Array, etc) and standard arrays that contain only numbers with a simple for… loop.
autodetects both situations (we could optionally unplug the number array detection) [EDIT: unplugged]
not compatible with BigInt typed arrays (Support BigInt? #75)

- interpolates typed arrays (Float64Array, etc) and standard arrays that contain only numbers with a simple for… loop. - autodetects both situations (we could optionally unplug the number array detection) - not compatible with BigInt typed arrays (#75)

Fil · 2019-11-19T18:47:21Z

supersedes #65 and #74

src/array.js

test/numberArray-test.js

src/numberArray.js

…mberArray

mbostock

Added a tiny optimization to avoid a redundant call to isNumberArray in the d3.interpolate code path.

preview URL: https://observablehq.com/d/9b417e049e687a65

bhousel · 2019-11-27T16:09:22Z

src/numberArray.js

+}
+
+export function isNumberArray(x) {
+  return ArrayBuffer.isView(x) && !(x instanceof DataView);


Hi! Just wanted to flag that typeof ArrayBuffer.isView === 'undefined' in PhantomJS. I know it's a super old browser and I'm not really expecting D3 to be perfectly compatible with it, but just commenting here in case someone else gets the same error. Thanks!

re: openstreetmap/iD#7072 (comment)

we could test for it?

return ArrayBuffer.isView && ArrayBuffer.isView(x) && !(x instanceof DataView);

interpolateNumberArray

cb34407

- interpolates typed arrays (Float64Array, etc) and standard arrays that contain only numbers with a simple for… loop. - autodetects both situations (we could optionally unplug the number array detection) - not compatible with BigInt typed arrays (#75)

Fil requested a review from mbostock November 19, 2019 18:46